fix(ui): constrain StreamMessageInput height when no constraint is given #2307
Conversation
When `StreamMessageInput` is used in an unconstrained environment, it tries to expand to fill all available vertical space. This change wraps the internal message input in a `Center` widget with `heightFactor: 1` to constrain its height.
WalkthroughA new entry was added to the changelog for the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant StreamMessageInput
participant CenterWidget
User->>StreamMessageInput: Uses StreamMessageInput in UI
StreamMessageInput->>CenterWidget: Builds child with heightFactor: 1
CenterWidget-->>StreamMessageInput: Sizes child without expanding to full height
StreamMessageInput-->>User: Renders correctly in unconstrained environment
Assessment against linked issues
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
packages/stream_chat_flutter/CHANGELOG.md (1)
5-5: Fix article & improve wording for clarityCurrent phrasing is grammatically off (“a unconstrained”) and a bit clunky.
Consider:- - Fixed `StreamMessageInput` tries to expand to full height when used in a unconstrained environment. + - Fixed issue where `StreamMessageInput` tried to expand to full height when used in an unconstrained environment.packages/stream_chat_flutter/lib/src/message_input/stream_message_input.dart (1)
665-667: Height constraint fix looks good – consider also settingwidthFactorfor symmetry
heightFactor: 1correctly prevents the input from stretching vertically in an unconstrained environment.For visual consistency (e.g., if this widget ever sits inside a
Rowwith unconstrained horizontal space), you might want to setwidthFactor: 1as well so theCenterkeeps both axes tied to the child’s size.- child: Center(heightFactor: 1, child: messageInput), + child: Center( + heightFactor: 1, + widthFactor: 1, // keeps horizontal sizing consistent + child: messageInput, + ),Purely optional – no functional issues with the current change.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
packages/stream_chat_flutter/CHANGELOG.md(1 hunks)packages/stream_chat_flutter/lib/src/message_input/stream_message_input.dart(1 hunks)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2307 +/- ##
=======================================
Coverage 63.50% 63.50%
=======================================
Files 409 409
Lines 25584 25584
=======================================
Hits 16247 16247
Misses 9337 9337 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 participants
Submit a pull request
Linear: FLU-200
Description of the pull request
When
StreamMessageInputis used in an unconstrained environment, it tries to expand to fill all available vertical space. This change wraps the internal message input in aCenterwidget withheightFactor: 1to constrain its height.Screenshots / Videos
Summary by CodeRabbit