Skip to content

Conversation

xsahil03x
Copy link
Member

@xsahil03x xsahil03x commented Sep 18, 2025

Fixes: #2366

Description of the pull request

The unread indicator button's text and close icon were previously hardcoded to white. This commit updates them to use colorTheme.barsBg from the current theme, ensuring they adapt correctly to different themes.

Summary by CodeRabbit

  • Bug Fixes

    • Unread indicator now respects app theme: the unread count label and close icon use the theme’s bars background color instead of a hardcoded white, improving visibility and consistency across light, dark, and custom themes.
  • Documentation

    • Changelog updated to document the UI theming fix for the unread indicator button.

The unread indicator button's text and close icon were previously hardcoded to white. This commit updates them to use `colorTheme.barsBg` from the current theme, ensuring they adapt correctly to different themes.
Copy link
Contributor

coderabbitai bot commented Sep 18, 2025

Walkthrough

Updated UnreadIndicatorButton to use StreamColorTheme's barsBg for text and icon colors instead of hardcoded white; updated CHANGELOG to record the theming fix referencing issue #2366. No API or control-flow changes.

Changes

Cohort / File(s) Summary
Theming update: UnreadIndicatorButton
packages/stream_chat_flutter/lib/src/message_list_view/unread_indicator_button.dart
Replaced hardcoded Colors.white with colorTheme.barsBg for unread count text and close icon foreground. No logic changes.
Changelog
packages/stream_chat_flutter/CHANGELOG.md
Added changelog entry noting the unread indicator button now uses colorTheme.barsBg; references #2366.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • renefloor

Poem

I thump with joy—no blinding white!
A softer hue now paints the night.
BarsBg sings where icons gleam,
The unread badge joins the theme.
In code we nibble, neat and tight—🥕✨

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "fix(ui): use correct theme color for unread indicator button" is a concise, single-sentence summary that directly describes the primary change (replacing hard-coded white with the theme color for the unread indicator), so it accurately and clearly reflects the PR's main intent.
Linked Issues Check ✅ Passed The PR replaces hard-coded white with colorTheme.barsBg in unread_indicator_button.dart and updates the changelog, which directly satisfies issue #2366's requirement that the UnreadIndicatorButton use StreamColorTheme.barsBg so it respects theming; no linked-issue coding requirements remain unmet based on the provided summaries.
Out of Scope Changes Check ✅ Passed All shown modifications are limited to the unread indicator widget and the package changelog and are related to theming the unread indicator as specified in issue #2366; there are no unrelated or out-of-scope code changes in the provided summaries.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/unread-indicator-button-theming

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 3978c79 and b6d9e3e.

📒 Files selected for processing (1)
  • packages/stream_chat_flutter/CHANGELOG.md (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • packages/stream_chat_flutter/CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
  • GitHub Check: build (ios)
  • GitHub Check: analyze
  • GitHub Check: build (android)
  • GitHub Check: test
  • GitHub Check: analyze_legacy_versions
  • GitHub Check: stream_chat_localizations
  • GitHub Check: stream_chat_flutter
  • GitHub Check: stream_chat_flutter_core
  • GitHub Check: stream_chat
  • GitHub Check: stream_chat_persistence

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

codecov bot commented Sep 18, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.81%. Comparing base (70c0f7e) to head (b6d9e3e).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...src/message_list_view/unread_indicator_button.dart 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2382      +/-   ##
==========================================
- Coverage   63.81%   63.81%   -0.01%     
==========================================
  Files         413      413              
  Lines       25837    25838       +1     
==========================================
  Hits        16488    16488              
- Misses       9349     9350       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xsahil03x xsahil03x force-pushed the fix/unread-indicator-button-theming branch from 80e5c1d to 3978c79 Compare September 19, 2025 00:26
renefloor
renefloor previously approved these changes Sep 23, 2025
@xsahil03x xsahil03x merged commit f85c293 into master Sep 23, 2025
16 of 19 checks passed
@xsahil03x xsahil03x deleted the fix/unread-indicator-button-theming branch September 23, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UnreadIndicatorButton text and icon color
2 participants