-
Notifications
You must be signed in to change notification settings - Fork 368
fix(ui): use correct theme color for unread indicator button #2382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The unread indicator button's text and close icon were previously hardcoded to white. This commit updates them to use `colorTheme.barsBg` from the current theme, ensuring they adapt correctly to different themes.
WalkthroughUpdated UnreadIndicatorButton to use StreamColorTheme's Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2382 +/- ##
==========================================
- Coverage 63.81% 63.81% -0.01%
==========================================
Files 413 413
Lines 25837 25838 +1
==========================================
Hits 16488 16488
- Misses 9349 9350 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
80e5c1d
to
3978c79
Compare
Fixes: #2366
Description of the pull request
The unread indicator button's text and close icon were previously hardcoded to white. This commit updates them to use
colorTheme.barsBg
from the current theme, ensuring they adapt correctly to different themes.Summary by CodeRabbit
Bug Fixes
Documentation