Skip to content

fix(ui): ensure dialog confirmation for delete/flag actions #2384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 19, 2025
Merged

fix(ui): ensure dialog confirmation for delete/flag actions #2384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5023b78
fix(ui): ensure dialog confirmation for delete/flag actions
xsahil03x Sep 19, 2025
a6c7755
chore: update CHANGELOG.md
xsahil03x Sep 19, 2025
40f3c65
Merge branch 'v10.0.0' into fix/message-delete-confirm-dismiss
xsahil03x Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/stream_chat_flutter/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
## Upcoming Beta

🐞 Fixed

- Fixed delete/flag message dialogs executing action when dialog is dismissed without confirmation.

## Upcoming

🐞 Fixed
Expand Down
4 changes: 2 additions & 2 deletions packages/stream_chat_flutter/lib/src/message_widget/message_widget.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1105,7 +1105,7 @@ class _StreamMessageWidgetState extends State<StreamMessageWidget>
),
);

if (confirmDelete == false) return null;
if (confirmDelete != true) return null;

return channel.deleteMessage(message);
}
Expand Down Expand Up @@ -1139,7 +1139,7 @@ class _StreamMessageWidgetState extends State<StreamMessageWidget>
),
);

if (confirmFlag == false) return null;
if (confirmFlag != true) return null;

final messageId = message.id;
return channel.client.flagMessage(messageId);
Expand Down