Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: merge custom data with current one rather than override #1364

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

isekovanic
Copy link
Contributor

CLA

  • I have signed the Stream CLA (required).
  • Code changes are tested

Description of the changes, What, Why and How?

This PR solves an issue where whenever custom data is being passed to an already existing channel, channel.data would be overwritten rather than merged with the custom data. This makes sure that this situation doesn't happen and that the channel is kept in tact regardless of what we passed.

Changelog

Copy link
Contributor

Size Change: +46 B (+0.01%)

Total Size: 427 kB

Filename Size Change
dist/browser.es.js 92.6 kB +8 B (+0.01%)
dist/browser.full-bundle.min.js 54.1 kB +12 B (+0.02%)
dist/browser.js 93.7 kB +10 B (+0.01%)
dist/index.es.js 92.6 kB +7 B (+0.01%)
dist/index.js 93.7 kB +9 B (+0.01%)

compressed-size-action

@isekovanic isekovanic merged commit ff59d54 into master Sep 13, 2024
5 checks passed
@isekovanic isekovanic deleted the fix/custom-data-override-issue branch September 13, 2024 14:01
@github-actions github-actions bot mentioned this pull request Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants