Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unread_count and unread_count_batch prep #153

Merged
merged 12 commits into from
Mar 1, 2024

Conversation

JimmyPettersson85
Copy link
Contributor

@JimmyPettersson85 JimmyPettersson85 commented Jan 23, 2024

Submit a pull request

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

stream_chat/async_chat/client.py Outdated Show resolved Hide resolved
stream_chat/async_chat/client.py Outdated Show resolved Hide resolved
stream_chat/async_chat/client.py Outdated Show resolved Hide resolved
stream_chat/async_chat/client.py Outdated Show resolved Hide resolved
@JimmyPettersson85 JimmyPettersson85 marked this pull request as ready for review January 23, 2024 12:57
@gumuz
Copy link
Contributor

gumuz commented Feb 14, 2024

@JimmyPettersson85 I guess the tests fail because the backend feature has not been rolled out yet?

@JimmyPettersson85
Copy link
Contributor Author

@JimmyPettersson85 I guess the tests fail because the backend feature has not been rolled out yet?

@gumuz correct, PR is pending for the endpoint in the chat repo

stream_chat/tests/async_chat/test_client.py Outdated Show resolved Hide resolved
stream_chat/tests/async_chat/test_client.py Outdated Show resolved Hide resolved
stream_chat/tests/async_chat/test_client.py Outdated Show resolved Hide resolved
stream_chat/tests/async_chat/test_client.py Outdated Show resolved Hide resolved
stream_chat/tests/test_client.py Outdated Show resolved Hide resolved
stream_chat/tests/test_client.py Outdated Show resolved Hide resolved
stream_chat/tests/test_client.py Outdated Show resolved Hide resolved
Copy link
Contributor

@gumuz gumuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@JimmyPettersson85 JimmyPettersson85 merged commit 56e8a5f into master Mar 1, 2024
6 checks passed
@JimmyPettersson85 JimmyPettersson85 deleted the unread-endpoints branch March 1, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants