feat: configure message group size by max time between messages #2439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-v11 #2439 +/- ##
============================================
Coverage 85.44% 85.44%
============================================
Files 392 392
Lines 9084 9084
Branches 2346 2346
============================================
Hits 7762 7762
Misses 1121 1121
Partials 201 201 ☔ View full report in Codecov by Sentry. |
oliverlaz
approved these changes
Jun 27, 2024
myandrienko
reviewed
Jun 27, 2024
myandrienko
approved these changes
Jun 27, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jun 28, 2024
## [11.23.0](v11.22.0...v11.23.0) (2024-06-28) ### Bug Fixes * adapt audio recording wave form to the available space ([#2435](#2435)) ([aed0360](aed0360)) * always load thread replies on Thread opening ([#2436](#2436)) ([579953c](579953c)) * forward groupStyles to Message in VirtualizedMessageList ([#2440](#2440)) ([241f5d7](241f5d7)) * reflect correctly the translation key in Timestamp component ([741e9ce](741e9ce)) ### Features * configure message group size by max time between messages ([#2439](#2439)) ([0d094cb](0d094cb))
|
🎉 This PR is included in version 11.23.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
The goal is the parity with RN Chat SDK.
🛠 Implementation details
If the value of
maxTimeBetweenGroupedMessagesis greater then the difference btw the current and next message creation date, the groupd is considered to end with the current message. Effectively, what happens is that the message is applied a classstr-chat__li--bottom. The visual result is reflected inMessageList(each message has timestamp and author (metadata) shown) but not inVirtualizedMessageListwhich has additional logic that decides whether a group ends at a given message. This should be synced with theMessageListbut potentially introducing breaking changes to the integrators usingVirtualizedMessageList:it_is_what_it_is_emoji.