-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unread messages divider did not appear in the message list when marking unread #3444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDK Size
|
SDK Performance
|
Generated by 🚫 Danger |
6832a7d
to
7574866
Compare
SDK Size
|
…ng messages as unread
7574866
to
dec8476
Compare
martinmitrevski
approved these changes
Oct 8, 2024
|
testableapple
approved these changes
Oct 9, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🐞 Bug
An issue or PR related to a bug
🟢 QAed
A PR that was QAed
🌐 SDK: StreamChat (LLC)
Tasks related to the StreamChat LLC SDK
🎨 SDK: StreamChatUI
Tasks related to the StreamChatUI SDK
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Resolves: PBE-5549
🎯 Goal
Fix an issue where unread messages divider did not appear on mark as unread
📝 Summary
🛠 Implementation
We need to find a previous message from the message we are marking as unread. API requires the last read message, not the first unread message id. The sorting logic and limiting the fetch to 1 ended up returning the oldest loaded message instead (filter matches, let's say 25 messages before limiting to 1, but we picked the id from the wrong end of results). Due to that reason, MessageListVC tried to reload cell for an older message instead (reloading is needed for making the cell to show the unread messages divider).
🎨 Showcase
🧪 Manual Testing Notes
Result: Unread message divider appears.
☑️ Contributor Checklist