Fix converting deleted database objects

[laevandus]

🔗 Issue Links

Part of IOS-23
Resolves IOS-20

🎯 Goal

Fix issues around deleting objects in the local database

📝 Summary

• Skip converting deleted database objects which lead to model objects returning empty properties
• Do not delete muted users when the current user object is deleted which leads to channel members having inconsistent state (member's user data is empty)
• Skip willSave if the DTO is in deleted state

🛠 Implementation

There have been crashes around accessing member data of the channel objects and one the possible culprits seems to be the automatic user deletion rule for the current user. User objects are shared between many objects and therefore should not be deleted like that. In addition, when an object is deleted, we should skip trying to convert these objects because the data is not present anymore (e.g. one can get a ChatMessage object with no properties being set, id is empty etc). That said, it is pretty rare since deleting data is not running often.

🧪 Manual Testing Notes

Running the demo app and doing some smoke testing which also includes logging out the current user.

☑️ Contributor Checklist

• I have signed the Stream CLA (required)
• This change should be manually QAed
• Changelog is updated with client-facing changes
• Changelog is updated with new localization keys
• New code is covered by unit tests
• Comparison screenshots added for visual changes
• Affected documentation updated (docusaurus, tutorial, CMS)

[Stream-SDK-Bot]

SDK Size

title	develop	branch	diff	status
StreamChat	6.96 MB	6.97 MB	+16 KB	🟢
StreamChatUI	4.95 MB	4.95 MB	0 KB	🟢

[Stream-SDK-Bot]

SDK Performance

target	metric	benchmark	branch	performance	status
MessageList	Hitches total duration	10 ms	5.01 ms	49.9% 🔼	🟢
	Duration	2.6 s	2.56 s	1.54% 🔼	🟢
	Hitch time ratio	4 ms per s	1.95 ms per s	51.25% 🔼	🟢
	Frame rate	75 fps	78.81 fps	5.08% 🔼	🟢
	Number of hitches	1	0.4	60.0% 🔼	🟢

[Stream-SDK-Bot]

SDK Size

title	develop	branch	diff	status
StreamChat	7.06 MB	7.06 MB	+1 KB	🟢
StreamChatUI	4.96 MB	4.96 MB	0 KB	🟢

[nuno-vieira]

LGTM! ✅

[sonarcloud]

Quality Gate passed

Issues
165 New issues
0 Accepted issues

Measures
0 Security Hotspots
83.7% Coverage on New Code
0.1% Duplication on New Code

See analysis details on SonarQube Cloud

[laevandus]

QAed with @testableapple