Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve swift warning #3499

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Resolve swift warning #3499

merged 2 commits into from
Nov 19, 2024

Conversation

testableapple
Copy link
Contributor

No description provided.

@testableapple testableapple added the 🌐 SDK: StreamChat (LLC) Tasks related to the StreamChat LLC SDK label Nov 19, 2024
@testableapple testableapple requested a review from a team as a code owner November 19, 2024 11:30
@github-actions GitHub Actions
Copy link

1 Message
📖 There seems to be app changes but CHANGELOG wasn't modified.
Please include an entry if the PR includes user-facing changes.
You can find it at CHANGELOG.md.

Generated by 🚫 Danger

@Stream-SDK-Bot
Copy link
Collaborator

SDK Size

title develop branch diff status
StreamChat 6.99 MB 6.99 MB 0 KB 🟢
StreamChatUI 4.95 MB 4.95 MB 0 KB 🟢

@Stream-SDK-Bot
Copy link
Collaborator

SDK Performance

target metric benchmark branch performance status
MessageList Hitches total duration 10 ms 8.35 ms 16.5% 🔼 🟢
Duration 2.6 s 2.55 s 1.92% 🔼 🟢
Hitch time ratio 4 ms per s 3.29 ms per s 17.75% 🔼 🟢
Frame rate 75 fps 78.29 fps 4.39% 🔼 🟢
Number of hitches 1 1.0 0.0% 🟰 🟢

@testableapple testableapple enabled auto-merge (squash) November 19, 2024 12:07
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
164 New issues
0 Accepted issues

Measures
0 Security Hotspots
84.3% Coverage on New Code
0.1% Duplication on New Code

See analysis details on SonarQube Cloud

@Stream-SDK-Bot
Copy link
Collaborator

SDK Size

title develop branch diff status
StreamChat 7.02 MB 7.02 MB 0 KB 🟢
StreamChatUI 4.96 MB 4.96 MB 0 KB 🟢

@testableapple testableapple merged commit 6ed5843 into develop Nov 19, 2024
11 of 12 checks passed
@testableapple testableapple deleted the fix/warning branch November 19, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuno-vieira nuno-vieira nuno-vieira approved these changes

@laevandus laevandus laevandus approved these changes

Assignees
No one assigned
Labels
🌐 SDK: StreamChat (LLC) Tasks related to the StreamChat LLC SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@testableapple @Stream-SDK-Bot @laevandus @nuno-vieira