Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sometimes failing test_loadPreviousReplies_whenMessagesAreEmpty_callDelegateWithEmptyChanges #3504

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

laevandus
Copy link
Contributor

🎯 Goal

Fix unstable test: test_loadPreviousReplies_whenMessagesAreEmpty_callDelegateWithEmptyChanges

🛠 Implementation

Unstable because it is checking delegate call counts, but did not properly wait for the initial background observer callback. This caused a race between initial fetch and the second load replies call. Failure was reproducible when running the unit-test locally with the repeat option.

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • Changelog is updated with new localization keys
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

…allDelegateWithEmptyChanges because of race between initial replies loading in the observer and delegate call count check
@laevandus laevandus added the 🤖 CI/CD Any work related to CI/CD label Nov 22, 2024
@laevandus laevandus requested a review from a team as a code owner November 22, 2024 10:43
@laevandus laevandus merged commit 3f9b2bf into develop Nov 22, 2024
13 checks passed
@laevandus laevandus deleted the ci/unstable-message-controller-test branch November 22, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 CI/CD Any work related to CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants