Skip to content

[CI] Get the correct target branch on public interface validation#3832

Closed
testableapple wants to merge 1 commit intodevelopfrom
ci/fix-public-interface-on-develop
Closed

[CI] Get the correct target branch on public interface validation#3832
testableapple wants to merge 1 commit intodevelopfrom
ci/fix-public-interface-on-develop

Conversation

@testableapple
Copy link
Contributor

@testableapple testableapple commented Oct 3, 2025

Summary by CodeRabbit

  • New Features
    • None.
  • Refactor
    • Reworked validation to compare current changes against the target branch with automatic branch restoration and clearer reporting.
  • Chores
    • Streamlined release and publish workflows by removing deprecated tasks and redundant configuration.
    • Improved CI gatekeeping and branch handling for more reliable runs and fewer false failures.
    • Reduced manual parameters in automation to simplify maintenance.

@testableapple testableapple requested a review from a team as a code owner October 3, 2025 11:13
@testableapple testableapple added the 🤖 CI/CD Any work related to CI/CD label Oct 3, 2025
@coderabbitai
Copy link

coderabbitai bot commented Oct 3, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Updates the Fastlane pipeline by adding an XcodeProj dependency, removing two Cocoapods-related lanes, simplifying release/publish calls, and reworking validate_public_interface to auto-detect the target branch, run analyses on current and target branches, diff results, and restore the original branch.

Changes

Cohort / File(s) Summary
Fastlane pipeline updates
fastlane/Fastfile
- Add require 'xcodeproj'
- Remove lanes: pod_lint, cocoapods_integration
- Remove podspec_names option from release/publish invocations
- Rework validate_public_interface: auto-detect target_branch (GITHUB_BASE_REF → main/develop), log target, analyze current branch, checkout target to analyze, diff/report, restore original branch
- CI/branch-handling control-flow adjustments

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant CI as CI
  participant FL as Fastlane
  participant GIT as Git
  participant ANA as Public Interface Analyzer

  Note over FL: validate_public_interface (updated flow)

  CI->>FL: Invoke lane
  FL->>FL: Determine target_branch (GITHUB_BASE_REF → main/develop)
  FL->>ANA: Analyze current branch API surface
  FL->>GIT: git checkout target_branch
  FL->>ANA: Analyze target branch API surface
  FL->>FL: Diff analyses and report
  FL->>GIT: Restore original branch
  FL-->>CI: Exit with status
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

Suggested reviewers

  • laevandus
  • martinmitrevski

Poem

A bunny hops through lanes so spry, 🐇
Drops pods, waves lint goodbye.
Sniffs branches—which to chase?
Diffs the tracks from place to place.
Carrot raised: “API is clean!”
Back to the burrow, swift and keen.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ci/fix-public-interface-on-develop

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between cfddb24 and 6744373.

📒 Files selected for processing (1)
  • fastlane/Fastfile (3 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@testableapple testableapple deleted the ci/fix-public-interface-on-develop branch October 3, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖 CI/CD Any work related to CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant