Skip to content

Add support for editing attachments #809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Apr 18, 2025
Merged

Add support for editing attachments #809

merged 16 commits into from
Apr 18, 2025

Conversation

nuno-vieira
Copy link
Member

Fix the merge commit, instead of rebase.

@nuno-vieira
Fix scrolling to the last message when editing a message
a6ee94b
@nuno-vieira
Add support for editing message attachments
94ee6cb
@nuno-vieira
Remove edit action from giphy message
f6686a1
@nuno-vieira
Fix being able to long press an unsent giphy message
5c74d02
@nuno-vieira
Fix being able to swipe to reply an unsent giphy
b93c034
@nuno-vieira
Fix fill composer function causing main thread warning
6e28963
@nuno-vieira
Update CHANGELOG.md
91f8d18
@nuno-vieira
Fix typo in deprecated message
daecfb1
@nuno-vieira
Fix double tapping on ephemeral giphy opening message actions
736dada
@nuno-vieira
Rename inputAttachmentsAsPayloads() -> `convertAddedAssetsToPayload…
c4f9b65 
…s()`
@nuno-vieira
Add test coverage to swipe to reply
0668acf
@nuno-vieira
Add test coverage to giphy edit action
b14b88d
@nuno-vieira
Extract attachments convert to a component so that it can be tested a…
09fdef5 
…nd reused
@nuno-vieira
Add test coverage to filling composer with edited message
1dd0f42
@nuno-vieira
Update CHANGELOG.md
61e30b6
@nuno-vieira
Added back the fillComposer function again
2dde7a4
@nuno-vieira nuno-vieira requested a review from a team as a code owner April 18, 2025 13:39
@nuno-vieira nuno-vieira merged commit 3f4b97d into develop Apr 18, 2025
16 of 17 checks passed
@nuno-vieira nuno-vieira deleted the fix/editing-custom-attachments branch April 18, 2025 13:39
@github-actions GitHub Actions
Copy link

1 Warning
⚠️ Big PR

Generated by 🚫 Danger

@Stream-SDK-Bot
Copy link
Collaborator

SDK Size

title develop branch diff status
StreamChatSwiftUI 8.21 MB 8.23 MB +18 KB 🟢

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nuno-vieira @Stream-SDK-Bot