Skip to content

Fix role deserialization. #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sierpinskid merged 1 commit into from
Apr 10, 2024
Merged

Fix role deserialization. #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Assets/Plugins/StreamChat/Core/InternalDTO/Models/ChannelMemberInternalDTO.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,7 @@ internal partial class ChannelMemberInternalDTO
/// Permission level of the member in the channel (DEPRECATED: use channel_role instead)
/// </summary>
[Newtonsoft.Json.JsonProperty("role", Required = Newtonsoft.Json.Required.Default, NullValueHandling = Newtonsoft.Json.NullValueHandling.Ignore)]
[Newtonsoft.Json.JsonConverter(typeof(Newtonsoft.Json.Converters.StringEnumConverter))]
public ChannelMemberRoleType? Role { get; set; }
public string Role { get; set; }

/// <summary>
/// Whether member is shadow banned in this channel or not
Expand Down
3 changes: 1 addition & 2 deletions Assets/Plugins/StreamChat/Core/InternalDTO/Requests/ChannelMemberRequestInternalDTO.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,7 @@ internal partial class ChannelMemberRequestInternalDTO
/// Permission level of the member in the channel (DEPRECATED: use channel_role instead)
/// </summary>
[Newtonsoft.Json.JsonProperty("role", Required = Newtonsoft.Json.Required.Default, NullValueHandling = Newtonsoft.Json.NullValueHandling.Ignore)]
[Newtonsoft.Json.JsonConverter(typeof(Newtonsoft.Json.Converters.StringEnumConverter))]
public ChannelMemberRoleType? Role { get; set; }
public string Role { get; set; }

/// <summary>
/// Whether member is shadow banned in this channel or not
Expand Down
2 changes: 1 addition & 1 deletion Assets/Plugins/StreamChat/Core/LowLevelClient/Models/ChannelMember.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public class ChannelMember : ModelBase, ILoadableFrom<ChannelMemberInternalDTO,
/// Permission level of the member in the channel (DEPRECATED: use channel_role instead)
/// </summary>
[Obsolete("Use ChannelRole instead")]
public ChannelMemberRoleType? Role { get; set; }
public string Role { get; set; }

/// <summary>
/// Whether member is shadow banned in this channel or not
Expand Down
6 changes: 4 additions & 2 deletions Assets/Plugins/StreamChat/Core/LowLevelClient/Requests/ChannelMemberRequest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using StreamChat.Core.Helpers;
using System;
using StreamChat.Core.Helpers;
using StreamChat.Core.InternalDTO.Models;
using StreamChat.Core.InternalDTO.Requests;

Expand Down Expand Up @@ -51,7 +52,8 @@ public partial class ChannelMemberRequest : RequestObjectBase, ISavableTo<Channe
/// <summary>
/// Permission level of the member in the channel (DEPRECATED: use channel_role instead)
/// </summary>
public ChannelMemberRoleType? Role { get; set; }
[Obsolete("Use ChannelRole instead")]
public string Role { get; set; }

/// <summary>
/// Whether member is shadow banned in this channel or not
Expand Down