Skip to content

Fix Feed state not fully cleared on feed deleted #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VelikovPetar merged 2 commits into from
Nov 14, 2025
Merged

Fix Feed state not fully cleared on feed deleted #147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ffc88a6
Fix Feed state not fully cleared on feed deleted
gpunto Nov 12, 2025
2d568e4
Merge branch 'develop' into fully-clear-fid-state-on-deletion
VelikovPetar Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...-client/src/main/kotlin/io/getstream/feeds/android/client/internal/state/FeedStateImpl.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,10 +218,14 @@ internal class FeedStateImpl(

override fun onFeedDeleted() {
_activities.update { emptyList() }
_aggregatedActivities.update { emptyList() }
_feed.update { null }
_followers.update { emptyList() }
_following.update { emptyList() }
_followRequests.update { emptyList() }
_pinnedActivities.update { emptyList() }
_notificationStatus.update { null }
_activitiesPagination = null
// Clear the member list state
memberListState.clear()
}
Expand Down
20 changes: 15 additions & 5 deletions ...ent/src/test/kotlin/io/getstream/feeds/android/client/internal/state/FeedStateImplTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ import io.mockk.mockk
import kotlinx.coroutines.test.runTest
import org.junit.Assert.assertEquals
import org.junit.Assert.assertNull
import org.junit.Assert.assertTrue
import org.junit.Test

internal class FeedStateImplTest {
Expand Down Expand Up @@ -400,20 +401,29 @@ internal class FeedStateImplTest {

@Test
fun `on onFeedDeleted, then clear all state`() = runTest {
val activity = activityData()
val notificationStatus = NotificationStatusResponse(unread = 5, unseen = 3)
setupInitialState(
activities = listOf(activityData()),
activities = listOf(activity),
aggregatedActivities = listOf(aggregatedActivityData()),
pinnedActivities = listOf(activityPin(activity)),
followers = listOf(followData()),
following = listOf(followData()),
followRequests = listOf(followData()),
)
feedState.onNotificationFeedUpdated(emptyList(), notificationStatus)

feedState.onFeedDeleted()

assertEquals(emptyList<ActivityData>(), feedState.activities.value)
assertTrue(feedState.activities.value.isEmpty())
assertTrue(feedState.aggregatedActivities.value.isEmpty())
assertTrue(feedState.pinnedActivities.value.isEmpty())
assertNull(feedState.feed.value)
assertEquals(emptyList<FollowData>(), feedState.followers.value)
assertEquals(emptyList<FollowData>(), feedState.following.value)
assertEquals(emptyList<FollowData>(), feedState.followRequests.value)
assertTrue(feedState.followers.value.isEmpty())
assertTrue(feedState.following.value.isEmpty())
assertTrue(feedState.followRequests.value.isEmpty())
assertNull(feedState.notificationStatus.value)
assertNull(feedState.activitiesPagination)
}

@Test
Expand Down