Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong api call from getEnrichedCustomActivities #106

Open
fso-msrl opened this issue Mar 24, 2022 · 2 comments
Open

Wrong api call from getEnrichedCustomActivities #106

fso-msrl opened this issue Mar 24, 2022 · 2 comments

Comments

@fso-msrl
Copy link

fso-msrl commented Mar 24, 2022

I want to use my custom enriched activity, and I tried to call getEnrichedCustomActivities, but it returns a list of activity data models.

I think it is because now this function is call getActivities api ([domain]/api/v1.0/feed/xxxx),
it should call getEnrichedActivities api ([domain]/api/v1.0/**enrich/**feed/xxxx), right?

@peterdeme
Copy link
Contributor

@fso-seekers using any of these methods should call the enrich endpoint

@fso-msrl
Copy link
Author

fso-msrl commented Mar 28, 2022

@peterdeme hm...but I want to use Custom and Enriched Activities. If I use getEnrichedActivities, I need to create the convertor by myself. For Example:

  1. call getEnrichedActivities
  2. convert to MyCustomEnrichedActivity List

So I want to use these, seems that if these works I no need to convert two times (json -> enrichedActivities -> MyCustomEnrichedActivity list)

In CloudFlatFeed.java, by your function name, should get Enriched and Custom activity list. If I missed understanding, would you mind telling me what cases I can use these functions?

CompletableFuture<List> getEnrichedCustomActivities(
Class type,
Limit limit,
Offset offset,
Filter filter,
EnrichmentFlags flags,
String ranking)
throws StreamException {
final RequestOption[] options =
ranking == null
? new RequestOption[] {limit, offset, filter, flags, DefaultOptions.DEFAULT_MARKER}
: new RequestOption[] {
limit, offset, filter, flags, DefaultOptions.DEFAULT_MARKER, new Ranking(ranking)
};
return getClient()
.getActivities(getID(), options) <-- works if call getEnrichedActivities?
.thenApply(
(Response response) -> {
try {
return deserializeContainer(response, type);
} catch (StreamException | IOException e) {
throw new CompletionException(e);
}
});
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants