Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove deprecated reaction.all method #365

Merged
merged 3 commits into from
Aug 12, 2020
Merged

remove deprecated reaction.all method #365

merged 3 commits into from
Aug 12, 2020

Conversation

mahboubii
Copy link
Contributor

BREAKING CHANGE:

  • reaction.all() is removed in favor of reaction.filter()

@github-actions
Copy link
Contributor

github-actions bot commented Aug 11, 2020 •
edited
Loading

Size Change: -201 B (0%)

Total Size: 101 kB

Filename Size Change
dist/js_min/getstream.js 31.3 kB -49 B (0%)
dist/js/getstream.js 69.4 kB -152 B (0%)

compressed-size-action

@mahboubii mahboubii changed the base branch from feature/typescript to master August 11, 2020 16:22
ferhatelmas
ferhatelmas approved these changes Aug 11, 2020
View reviewed changes
Copy link
Contributor

@ferhatelmas ferhatelmas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mahboubii mahboubii merged commit 92ce850 into master Aug 12, 2020
@mahboubii mahboubii deleted the deprecated/remove-reaction-all-method branch August 12, 2020 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferhatelmas ferhatelmas ferhatelmas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mahboubii @ferhatelmas