Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix outdated preview data docs #1153

Merged
merged 3 commits into from
Aug 7, 2024
Merged

Fix outdated preview data docs #1153

merged 3 commits into from
Aug 7, 2024

Conversation

skydoves
Copy link
Member

@skydoves skydoves commented Aug 7, 2024

🎯 Goal

Fix outdated preview data docs.

@skydoves skydoves self-assigned this Aug 7, 2024
@skydoves skydoves requested a review from a team as a code owner August 7, 2024 06:36
@liviu-timar
Copy link
Member

liviu-timar commented Aug 7, 2024 •
edited
Loading

I found references to the mock class here as well. ✅

liviu-timar
liviu-timar requested changes Aug 7, 2024
View reviewed changes
Copy link
Member

@liviu-timar liviu-timar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VideoTheme.colors.appBackground doesn't exist anymore. I'll update it. ✅

@liviu-timar liviu-timar merged commit 6387688 into develop Aug 7, 2024
7 checks passed
@liviu-timar liviu-timar deleted the update/docs-previewdata branch August 7, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liviu-timar liviu-timar liviu-timar approved these changes

Assignees

@skydoves skydoves

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skydoves @liviu-timar