Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PBE-3853] Support noise cancellation #1196

Merged
merged 89 commits into from
Oct 9, 2024
Merged

[PBE-3853] Support noise cancellation #1196

merged 89 commits into from
Oct 9, 2024

Conversation

kanat
Copy link
Contributor

@kanat kanat commented Oct 2, 2024

🎯 Goal

Closes:

Noise Cancellation implementation is located in the following repository:

✅ Depends On

☑️Contributor Checklist

General

  • I have signed the Stream CLA (required)
  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (required internally)
  • PR targets the develop branch
  • PR is linked to the GitHub issue it resolves

Code & documentation

  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (KDocs, docusaurus, tutorial)
  • Tutorial starter kit updated
  • Examples/guides starter kits updated (stream-video-examples)

☑️Reviewer Checklist

  • XML sample runs & works
  • Compose sample runs & works
  • Tutorial starter kit
  • Example starter kits work
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • Release notes and docs clearly describe changes
  • All code we touched has new or updated KDocs

🎉 GIF

Please provide a suitable gif that describes your work on this pull request

skydoves and others added 30 commits June 22, 2023 15:59
Develop commits against the main branch
Develop commits against the main branch
Develop commits against the main branch
Develop commits against the main bracnh
Increment the patch version & Update baseline profiles
Develop commits against the main branch
@kanat kanat marked this pull request as ready for review October 8, 2024 19:12
@kanat kanat requested a review from a team as a code owner October 8, 2024 19:12
@kanat kanat merged commit 8329e59 into develop Oct 9, 2024
6 checks passed
@kanat kanat deleted the feature/audio-filter branch October 9, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants