Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(llc): Reconnects v2 #768

Merged
merged 5 commits into from
Oct 30, 2024
Merged

feature(llc): Reconnects v2 #768

merged 5 commits into from
Oct 30, 2024

Conversation

Brazol
Copy link
Contributor

@Brazol Brazol commented Sep 23, 2024 •
edited
Loading

Overview

Implements the Reconnects v2 flow. The implementation doesn't change the public API (not breaking); internally, it does change many things. The Reconnects v2 consists of three reconnect strategies:

  • FAST: typically used when switching networks (wifi->5g or similar). This strategy takes the SFU-provided threshold, which normally is set to 25 seconds. The client attempts to connect to the same SFU and performs an ICE restart on the existing peer connections.
  • REJOIN: used when FAST isn't applicable, failed or the SFU told us to do it. Drops all existing peer connections, closes the web socket to the SFU, fetches new credentials from the Coordinator, and finally establishes a connection to the SFU returned by the coordinator. The important detail here is, that we rejoin with a new session_id parameter. This strategy is analogous to a browser tab refresh.
  • MIGRATE: when the SFU reaches its operational capacity or when it gets shut down due to maintenance or upgrade, it will ask connected clients to migrate away to another, healthy SFU. The migration is marked as complete, once the participantMigrationComplete event is emitted. If the migration fails, the client automatically attempts REJOIN.
  • DISCONNECT: The SFU politely asks you to leave the call

@Brazol Brazol requested a review from a team as a code owner September 23, 2024 14:46
@Brazol Brazol changed the title chore(llc): regenerage OpenAPI models chore(llc): regenerate OpenAPI models Sep 23, 2024
deven98
deven98 approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@deven98 deven98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Brazol
Reconnect v2 with updated join flow (#776)
ec3ec36 
* reconnect v2

* reconnect v2 with updated join flow

* tweaks

* adjustments to event handling

* peer connection issue fixes

* improving migration

* fix

* tweaks

* tweaks

* ending ringing fixes

* dogfooding tweaks

* cleanup

* fix for sending ui subs when call is already closed

* call tweaks

* extend the interval for network checks.
@Brazol Brazol changed the title chore(llc): regenerate OpenAPI models feature(llc): Reconnects v2 Oct 30, 2024
@Brazol Brazol merged commit aa02db1 into main Oct 30, 2024
3 checks passed
@Brazol Brazol deleted the chore/openAPI-regeneration branch October 30, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deven98 deven98 deven98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Brazol @deven98