Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(llc): Added participants count in CallState #790

Merged
merged 6 commits into from
Nov 5, 2024
Merged

Conversation

Brazol
Copy link
Contributor

@Brazol Brazol commented Oct 31, 2024

Overview

Handlers for the call.session_participant_count_updated event.
The Coordinator will occasionally deliver this event to all clients, and it will carry the most recent state of:

anonymous_participant_count and participant_count_by_role

Implementation notes

watch parameter is now added to Call.get() and Call.getOrCreate() methods. When set to true the coordinator events will be listened to even before joining the call.

The CallState is extended with participantCount and anonymousParticipantCount fields.
This values from the call.session_participant_count_updated event are used to update those fields but only when the call status isn't JOINED. Once the call is JOINED, these values will be populated from the SFU heart checks.

@Brazol Brazol marked this pull request as ready for review November 1, 2024 08:16
@Brazol Brazol requested a review from a team as a code owner November 1, 2024 08:16
@Brazol Brazol requested a review from deven98 November 1, 2024 08:18
Copy link
Contributor

@deven98 deven98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Brazol Brazol merged commit f94fb89 into main Nov 5, 2024
3 checks passed
@Brazol Brazol deleted the feat/participan-count branch November 5, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants