Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input: Phone, currency and percentage masks not working correctly #1167

Closed
benjamincharity opened this issue Dec 14, 2018 · 1 comment
Closed

Input: Phone, currency and percentage masks not working correctly #1167

benjamincharity opened this issue Dec 14, 2018 · 1 comment
Assignees
@benjamincharity
Labels
Focus: component Issues concerning a specific component P2: Urgent Target: latest Issues related to the latest version of the library (master) Type: bug An implemented item with undesired effects

Comments

@benjamincharity
Copy link
Contributor

benjamincharity commented Dec 14, 2018 •
edited
Loading

CURRENTLY: every other character correctly masks. ie:

  • (1
  • 11
  • (111
  • 1111
  • (111) 11
  • etc

NOTE:

  • Phone mask works with ngModel, but not with FormControl.
  • If sanitize is turned off, it works perfectly. So the issue seems to be with our CVA.
@benjamincharity benjamincharity added Focus: component Issues concerning a specific component P2: Urgent Type: bug An implemented item with undesired effects labels Dec 14, 2018
@shani-terminus shani-terminus changed the title Input(v10): Phone mask not working correctly Input(v10): Phone and percentage masks not working correctly Dec 19, 2018
@shani-terminus shani-terminus changed the title Input(v10): Phone and percentage masks not working correctly Input(v10): Phone, currency and percentage masks not working correctly Dec 20, 2018
@benjamincharity benjamincharity added the Target: latest Issues related to the latest version of the library (master) label Jan 2, 2019
@benjamincharity benjamincharity changed the title Input(v10): Phone, currency and percentage masks not working correctly Input: Phone, currency and percentage masks not working correctly Jan 7, 2019
@benjamincharity benjamincharity mentioned this issue Feb 18, 2019
Closed
benjamincharity added a commit that referenced this issue Feb 19, 2019
@benjamincharity
fix(Input): sanitized mask value no longer overwriting UI
a089b81 
ISSUES CLOSED: #1167
@benjamincharity benjamincharity mentioned this issue Feb 19, 2019
Merged
benjamincharity added a commit that referenced this issue Feb 19, 2019
@benjamincharity
fix(Input): sanitized mask value no longer overwriting UI
ed2bfd9 
ISSUES CLOSED: #1167
@benjamincharity
Copy link
Contributor Author

🎉 This issue has been resolved in version 11.1.17 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benjamincharity benjamincharity

Labels
Focus: component Issues concerning a specific component P2: Urgent Target: latest Issues related to the latest version of the library (master) Type: bug An implemented item with undesired effects
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benjamincharity @shani-terminus