Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Card: disabled property should be named isDisabled #1267

Closed
6 tasks done
benjamincharity opened this issue Jan 29, 2019 · 0 comments
Closed
6 tasks done

Card: disabled property should be named isDisabled #1267

benjamincharity opened this issue Jan 29, 2019 · 0 comments
Assignees
@shani-terminus
Labels
💥 BREAKING CHANGE 💥 This issue is a breaking change requiring a major version bump Focus: component Issues concerning a specific component Type: chore Something that needs to be done but is not a bug or addition

Comments

@benjamincharity
Copy link
Contributor

benjamincharity commented Jan 29, 2019 •
edited by shani-terminus
Loading

We should align this input with our other existing inputs. Target v12.

💥 Breaking change 💥

  • Remove disabled input from TsCard
  • Update template to reference isDisabled
  • Remove disabled tests (isDisabled tests already exist)
  • Update usage docs
  • Update demo
  • Write migration notes for release
@benjamincharity benjamincharity added Focus: component Issues concerning a specific component Target: v12 Type: chore Something that needs to be done but is not a bug or addition labels Jan 29, 2019
@benjamincharity benjamincharity added the 💥 BREAKING CHANGE 💥 This issue is a breaking change requiring a major version bump label Feb 14, 2019
@benjamincharity benjamincharity self-assigned this Feb 14, 2019
@benjamincharity benjamincharity removed their assignment Apr 1, 2019
@shani-terminus shani-terminus self-assigned this Apr 3, 2019
shani-terminus added a commit that referenced this issue Apr 3, 2019
@shani-terminus
chore(Card): *BREAKING CHANGE* removed \disabled\ input
b388e72 
BREAKING CHANGE:
Card will have to use isDisabled instead of disabled

ISSUES CLOSED: #1267
@shani-terminus shani-terminus mentioned this issue Apr 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shani-terminus shani-terminus

Labels
💥 BREAKING CHANGE 💥 This issue is a breaking change requiring a major version bump Focus: component Issues concerning a specific component Type: chore Something that needs to be done but is not a bug or addition
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benjamincharity @shani-terminus