Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IconButton: Convert to integration test #1284

Closed
benjamincharity opened this issue Jan 30, 2019 · 0 comments
Closed

IconButton: Convert to integration test #1284

benjamincharity opened this issue Jan 30, 2019 · 0 comments
Assignees
@shani-terminus
Labels
Focus: testing Tests or test helpers Target: latest Issues related to the latest version of the library (master) Type: chore Something that needs to be done but is not a bug or addition

Comments

@benjamincharity
Copy link
Contributor

benjamincharity commented Jan 30, 2019 •
edited
Loading

Currently this is still using the old method of 'newing' up the component class. We should convert this to use the TestBed and fully test it.
@benjamincharity benjamincharity added Focus: testing Tests or test helpers Type: chore Something that needs to be done but is not a bug or addition Target: latest Issues related to the latest version of the library (master) labels Jan 30, 2019
@shani-terminus shani-terminus self-assigned this Mar 28, 2019
shani-terminus added a commit that referenced this issue Mar 28, 2019
@shani-terminus
chore(IconButton): now with integration tests
db64587 
ISSUES CLOSED: #1284
@shani-terminus shani-terminus mentioned this issue Mar 28, 2019
Merged
benjamincharity pushed a commit that referenced this issue Mar 28, 2019
@shani-terminus @benjamincharity
chore(IconButton): now with integration tests
1ab6e85 
ISSUES CLOSED: #1284
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shani-terminus shani-terminus

Labels
Focus: testing Tests or test helpers Target: latest Issues related to the latest version of the library (master) Type: chore Something that needs to be done but is not a bug or addition
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benjamincharity @shani-terminus