Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VerticalSpacing: Convert to integration test #1294

Closed
benjamincharity opened this issue Jan 30, 2019 · 0 comments · Fixed by #1481
Closed

VerticalSpacing: Convert to integration test #1294

benjamincharity opened this issue Jan 30, 2019 · 0 comments · Fixed by #1481
Assignees
@shani-terminus
Labels
Focus: testing Tests or test helpers Target: latest Issues related to the latest version of the library (master) Type: chore Something that needs to be done but is not a bug or addition

Comments

@benjamincharity
Copy link
Contributor

benjamincharity commented Jan 30, 2019 •
edited
Loading

Currently this is still using the old method of 'newing' up the component class. We should convert this to use the TestBed and fully test it.
@benjamincharity benjamincharity added Focus: testing Tests or test helpers Type: chore Something that needs to be done but is not a bug or addition Target: latest Issues related to the latest version of the library (master) labels Jan 30, 2019
shani-terminus added a commit that referenced this issue Apr 23, 2019
@shani-terminus
chore(Spacing): has integration tests
0131164 
ISSUES CLOSED: #1294
@shani-terminus shani-terminus mentioned this issue Apr 23, 2019
Merged
shani-terminus added a commit that referenced this issue Apr 24, 2019
@shani-terminus
chore(Spacing): has integration tests
1996423 
ISSUES CLOSED: #1294
benjamincharity pushed a commit that referenced this issue Apr 25, 2019
@shani-terminus @benjamincharity
chore(Spacing): has integration tests (#1481)
b08f5e8 
ISSUES CLOSED: #1294
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shani-terminus shani-terminus

Labels
Focus: testing Tests or test helpers Target: latest Issues related to the latest version of the library (master) Type: chore Something that needs to be done but is not a bug or addition
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(Spacing): has integration tests GetTerminus/terminus-ui
2 participants
@benjamincharity @shani-terminus