Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select: Make filter placeholder/label more explicit #1352

Closed
shani-terminus opened this issue Feb 12, 2019 · 2 comments
Closed

Select: Make filter placeholder/label more explicit #1352

shani-terminus opened this issue Feb 12, 2019 · 2 comments
Assignees
@shani-terminus
Labels
Focus: component Issues concerning a specific component Target: latest Issues related to the latest version of the library (master) Type: feature Functionality that doesn't currently exist

Comments

@shani-terminus
Copy link
Contributor

shani-terminus commented Feb 12, 2019 •
edited by benjamincharity
Loading

Update select filter text to be more explicit:

New text: Begin typing to filter...

Originally reported by Niraj.

Original issue content

Niraj reported a user having confusion over the word "filter..." in this select.
The solution has yet to be determined.

  • Do we simply want to change this text? If so, what should it be?
  • Does this text need to be customizable? If so, what should the default text be?
  • Is this a problem for enough users to even warrant a change? If not, close this ticket!
  • Something else?
screen shot 2019-02-12 at 9 28 32 am

Code:
https://github.com/GetTerminus/terminus-ui/blob/master/terminus-ui/select/src/select.component.html#L164
@shani-terminus shani-terminus added Type: feature Functionality that doesn't currently exist Needs: exploration Issues that need more information before being worked on Focus: component Issues concerning a specific component labels Feb 12, 2019
@dpeet

This comment has been minimized.

Sign in to view
@benjamincharity benjamincharity added the Needs: planning Items that need discovery/refinement/details/etc label Feb 20, 2019
@benjamincharity

This comment has been minimized.

Sign in to view
@benjamincharity benjamincharity added Target: latest Issues related to the latest version of the library (master) and removed Needs: exploration Issues that need more information before being worked on Needs: planning Items that need discovery/refinement/details/etc labels Mar 18, 2019
@benjamincharity benjamincharity changed the title Select: change filter label Select: Make filter placeholder/label more explicit Mar 18, 2019
@shani-terminus shani-terminus self-assigned this Mar 18, 2019
shani-terminus added a commit that referenced this issue Mar 18, 2019
@shani-terminus
feat(Select): updated filter label text
fc6aef0 
ISSUES CLOSED: #1352
@shani-terminus shani-terminus mentioned this issue Mar 18, 2019
Merged
shani-terminus added a commit that referenced this issue Mar 20, 2019
@shani-terminus
fix(Select): updated filter label text
41f577e 
ISSUES CLOSED: #1352
benjamincharity pushed a commit that referenced this issue Mar 25, 2019
@shani-terminus @benjamincharity
fix(Select): updated filter label text
23dafa7 
ISSUES CLOSED: #1352
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shani-terminus shani-terminus

Labels
Focus: component Issues concerning a specific component Target: latest Issues related to the latest version of the library (master) Type: feature Functionality that doesn't currently exist
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@benjamincharity @dpeet @shani-terminus