Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select: Fix hardcoded SCSS items #1378

Closed
5 tasks done
benjamincharity opened this issue Feb 20, 2019 · 0 comments
Closed
5 tasks done

Select: Fix hardcoded SCSS items #1378

benjamincharity opened this issue Feb 20, 2019 · 0 comments
Assignees
Labels
Focus: component Issues concerning a specific component Target: latest Issues related to the latest version of the library (master) Type: chore Something that needs to be done but is not a bug or addition

Comments

@benjamincharity
Copy link
Contributor

benjamincharity commented Feb 20, 2019

https://github.com/GetTerminus/terminus-ui/blob/master/terminus-ui/select/src/select.component.scss#L122-L126

  • padding should be spacing(small, 1)
  • right should be -#{spacing(large, 1)}
  • panel-header should be added to the z-index map above menu in _z-index.scss
  • _z-index.scss should be added to imports
  • z-index should be z(panel-header)
@benjamincharity benjamincharity added Focus: component Issues concerning a specific component Target: latest Issues related to the latest version of the library (master) Type: chore Something that needs to be done but is not a bug or addition labels Feb 20, 2019
@shani-terminus shani-terminus self-assigned this Mar 15, 2019
shani-terminus added a commit that referenced this issue Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Focus: component Issues concerning a specific component Target: latest Issues related to the latest version of the library (master) Type: chore Something that needs to be done but is not a bug or addition
Projects
None yet
Development

No branches or pull requests

2 participants