Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Freeze lock file during install #1383

Closed
benjamincharity opened this issue Feb 26, 2019 · 1 comment
Closed

CI: Freeze lock file during install #1383

benjamincharity opened this issue Feb 26, 2019 · 1 comment
Assignees
@benjamincharity
Labels
Focus: build Issues concerning our CI or build process' Target: latest Issues related to the latest version of the library (master) Type: chore Something that needs to be done but is not a bug or addition

Comments

@benjamincharity
Copy link
Contributor

yarn install can change the yarn.lock file. Because of this we should change the CI yarn install command to yarn install --frozen-lockfile to ensure dependencies do not change.
@benjamincharity benjamincharity added Focus: build Issues concerning our CI or build process' Type: chore Something that needs to be done but is not a bug or addition Target: latest Issues related to the latest version of the library (master) labels Feb 26, 2019
@benjamincharity benjamincharity self-assigned this Feb 26, 2019
@benjamincharity benjamincharity mentioned this issue Feb 26, 2019
Closed
4 tasks
@benjamincharity
Copy link
Contributor Author

Merging into #1384

shani-terminus added a commit that referenced this issue Mar 28, 2019
@shani-terminus
chore(Card): 100% test coverage
2d55b23 
ISSUES CLOSED: #1383
@shani-terminus shani-terminus mentioned this issue Mar 28, 2019
Merged
benjamincharity pushed a commit that referenced this issue Mar 29, 2019
@shani-terminus @benjamincharity
chore(Card): 100% test coverage
f32aa4b 
ISSUES CLOSED: #1383
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benjamincharity benjamincharity

Labels
Focus: build Issues concerning our CI or build process' Target: latest Issues related to the latest version of the library (master) Type: chore Something that needs to be done but is not a bug or addition
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@benjamincharity