Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sass helpers: Change all warnings to errors #1456

Closed
1 task
benjamincharity opened this issue Apr 10, 2019 · 1 comment · Fixed by #1474
Closed
1 task

Sass helpers: Change all warnings to errors #1456

benjamincharity opened this issue Apr 10, 2019 · 1 comment · Fixed by #1474
Assignees
Labels
Focus: utility Helpers etc. Goal: Library Stabilization A task needed to get the library closer to it's final state Target: latest Issues related to the latest version of the library (master) Type: bug An implemented item with undesired effects

Comments

@benjamincharity
Copy link
Contributor

Our Sass helper functions/mixins should alert the user if used incorrectly. Angular CLI seems to be suppressing @warn messages from our helpers so we need to switch them to @error.

IMO it's not the best workflow to stop compilation for style errors. But since a warning doesn't make it through to the consumer this is the only way to avoid very difficult to track down bugs.

Reproduction

  1. Pass an incorrect value to a Sass helper (e.g. z-index: z(foo);)
  2. See no warning in the cli

Which versions of this library, Angular, TypeScript, & browsers are affected?

  • UI Library: all versions
  • Angular: v7
  • TypeScript: 3.1.6

  • Change all instances of @warn in our Sass files to @error
@benjamincharity benjamincharity added Focus: utility Helpers etc. Goal: Library Stabilization A task needed to get the library closer to it's final state Target: latest Issues related to the latest version of the library (master) Type: bug An implemented item with undesired effects labels Apr 10, 2019
@shani-terminus
Copy link
Contributor

I noticed in my local after a bad input was corrected, I would sometimes get an error: Cannot read property 'toString' of undefined. This went away when I stopped the build:ts:watch and ran it again.

shani-terminus added a commit that referenced this issue Apr 22, 2019

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…e displayed

ISSUES CLOSED: #1456
benjamincharity pushed a commit that referenced this issue Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Focus: utility Helpers etc. Goal: Library Stabilization A task needed to get the library closer to it's final state Target: latest Issues related to the latest version of the library (master) Type: bug An implemented item with undesired effects
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants