Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RadioGroup: Adjustment to visual checkbox small size #1569

Closed
4 tasks done
benjamincharity opened this issue Jun 24, 2019 · 2 comments
Closed
4 tasks done

RadioGroup: Adjustment to visual checkbox small size #1569

benjamincharity opened this issue Jun 24, 2019 · 2 comments
Assignees
Labels
Focus: component Issues concerning a specific component Goal: Library Stabilization A task needed to get the library closer to it's final state Target: latest Issues related to the latest version of the library (master) Type: feature Functionality that doesn't currently exist

Comments

@benjamincharity
Copy link
Contributor

benjamincharity commented Jun 24, 2019

This change is needed for LinkedIn Forms.

Currently, the 'small' visual mode simply a smaller responsive ratio. Moving forward, UX would like more control over the display of the visual checkbox.

⚠️ NOTE: This ticket should only affect the small visual radio.

  • Remove the responsive mixin and hardcode the width to 13.75rem
  • The height should also be hardcoded to a height using rems that allows for:
    • 2 title lines
    • 3 body lines
    • The appropriate top/bottom padding
  • Update the component JSDoc comment to include all possible inputs & outputs
  • Update usage docs to include instructions about how to use the 'small' visual mode
@benjamincharity benjamincharity added Focus: component Issues concerning a specific component Goal: Library Stabilization A task needed to get the library closer to it's final state Target: latest Issues related to the latest version of the library (master) Type: feature Functionality that doesn't currently exist labels Jun 24, 2019
@dpeet
Copy link

dpeet commented Jun 24, 2019

Related problem (that may need to be it's own issue) is adding the shadow mixin to all of the radio buttons so they are more "button" like

@benjamincharity
Copy link
Contributor Author

@dpeet I went ahead and popped that off into it's own issue #1574

shani-terminus added a commit that referenced this issue Jul 10, 2019
it can accommodate 2 lines of title text and 3 lines of body text

ISSUES CLOSED: #1569
benjamincharity pushed a commit that referenced this issue Jul 12, 2019
it can accommodate 2 lines of title text and 3 lines of body text

ISSUES CLOSED: #1569
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Focus: component Issues concerning a specific component Goal: Library Stabilization A task needed to get the library closer to it's final state Target: latest Issues related to the latest version of the library (master) Type: feature Functionality that doesn't currently exist
Projects
None yet
Development

No branches or pull requests

3 participants