Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RadioGroup: Visual mode allow top aligned content #1570

Closed
5 tasks done
benjamincharity opened this issue Jun 24, 2019 · 0 comments · Fixed by #1612
Closed
5 tasks done

RadioGroup: Visual mode allow top aligned content #1570

benjamincharity opened this issue Jun 24, 2019 · 0 comments · Fixed by #1612
Assignees
@benjamincharity
Labels
Focus: component Issues concerning a specific component Goal: Library Stabilization A task needed to get the library closer to it's final state Target: latest Issues related to the latest version of the library (master) Type: feature Functionality that doesn't currently exist

Comments

@benjamincharity
Copy link
Contributor

benjamincharity commented Jun 24, 2019 •
edited
Loading

This change is needed for LinkedIn Forms.

Currently the contents for visual radio button is centered vertically and horizontally. This can cause odd layouts as the top alignment of text changes as the length of content changes. UX is requesting a mode that is top/left aligned.

  • Add @input centeredContent that defaults to true (so that this is not a breaking change)
  • When false the content should be top and left aligned as is standard
  • Add to usage docs
  • Add tests
  • Add option to demo so the user can toggle centered on/off in the visual demo
@benjamincharity benjamincharity added Focus: component Issues concerning a specific component Goal: Library Stabilization A task needed to get the library closer to it's final state Target: latest Issues related to the latest version of the library (master) Type: feature Functionality that doesn't currently exist labels Jun 24, 2019
@benjamincharity benjamincharity self-assigned this Jul 16, 2019
benjamincharity added a commit that referenced this issue Jul 31, 2019
@benjamincharity
feat(RadioGroup): now supports centered content OR left/top aligned c…
5d437ad 
…ontent

ISSUES CLOSED: #1570
@benjamincharity benjamincharity mentioned this issue Jul 31, 2019
Merged
benjamincharity added a commit that referenced this issue Jul 31, 2019
@benjamincharity
feat(RadioGroup): now supports centered content OR left/top aligned c…
b82a3fa 
…ontent

ISSUES CLOSED: #1570
benjamincharity added a commit that referenced this issue Aug 1, 2019
@benjamincharity
feat(RadioGroup): now supports centered content OR left/top aligned c…
952e21b 
…ontent

ISSUES CLOSED: #1570
benjamincharity added a commit that referenced this issue Aug 1, 2019
@benjamincharity
feat(RadioGroup): now supports centered content OR left/top aligned c…
91d327c 
…ontent

ISSUES CLOSED: #1570
benjamincharity added a commit that referenced this issue Aug 5, 2019
@benjamincharity
feat(RadioGroup): now supports centered content OR left/top aligned c…
7c540f6 
…ontent

ISSUES CLOSED: #1570
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benjamincharity benjamincharity

Labels
Focus: component Issues concerning a specific component Goal: Library Stabilization A task needed to get the library closer to it's final state Target: latest Issues related to the latest version of the library (master) Type: feature Functionality that doesn't currently exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(RadioGroup): now supports centered content OR left/top aligned content GetTerminus/terminus-ui
1 participant
@benjamincharity