Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort: Update styles that signify the ability to sort columns #1739

Closed
3 tasks done
benjamincharity opened this issue Oct 3, 2019 · 0 comments
Closed
3 tasks done

Sort: Update styles that signify the ability to sort columns #1739

benjamincharity opened this issue Oct 3, 2019 · 0 comments
Assignees
@benjamincharity
Labels
Focus: component Issues concerning a specific component Target: latest Issues related to the latest version of the library (master) Type: feature Functionality that doesn't currently exist

Comments

@benjamincharity
Copy link
Contributor

benjamincharity commented Oct 3, 2019 •
edited
Loading

Currently it's a bit vague that a column can be sorted. This should be made more clear.

  • Sortable columns, that are not yet sorted, should have the swap_vert icon visible on hover
    • the existing icons defining the sort direction can stay as they are.
  • Icon should match the text color (initially black, then accent on hover)
  • Remove the thick underline for sortable columns

Screen Shot 2019-10-04 at 7.01.37 AM.png
@benjamincharity benjamincharity added Focus: component Issues concerning a specific component Target: latest Issues related to the latest version of the library (master) Type: feature Functionality that doesn't currently exist labels Oct 3, 2019
@benjamincharity benjamincharity self-assigned this Oct 3, 2019
benjamincharity added a commit that referenced this issue Oct 16, 2019
@benjamincharity
feat(Sort): better visual representation a column is sortable
3171a0b 
ISSUES CLOSED: #1739
benjamincharity added a commit that referenced this issue Oct 16, 2019
@benjamincharity
feat(Sort): better visual representation a column is sortable
f16c833 
ISSUES CLOSED: #1739
benjamincharity added a commit that referenced this issue Oct 16, 2019
@benjamincharity
feat(Sort): better visual representation a column is sortable
fdeffa1 
ISSUES CLOSED: #1739
benjamincharity added a commit that referenced this issue Oct 16, 2019
@benjamincharity
feat(Sort): better visual representation a column is sortable
cfdbb63 
ISSUES CLOSED: #1739
benjamincharity added a commit that referenced this issue Oct 23, 2019
@benjamincharity
feat(Sort): better visual representation a column is sortable
5696a46 
ISSUES CLOSED: #1739
benjamincharity added a commit that referenced this issue Oct 25, 2019
@benjamincharity
feat(Sort): better visual representation a column is sortable
7bcd821 
ISSUES CLOSED: #1739
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benjamincharity benjamincharity

Labels
Focus: component Issues concerning a specific component Target: latest Issues related to the latest version of the library (master) Type: feature Functionality that doesn't currently exist
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@benjamincharity