Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(formControl): now form control supports no validation mode. #2005

Merged
merged 2 commits into from
Feb 6, 2020
Merged

feat(formControl): now form control supports no validation mode. #2005

merged 2 commits into from
Feb 6, 2020

Conversation

atlwendy
Copy link
Contributor

@atlwendy atlwendy commented Feb 4, 2020

closes #1752

@atlwendy atlwendy requested a review from a team as a code owner February 4, 2020 19:36
@ghost ghost assigned atlwendy Feb 4, 2020
@codecov
Copy link

codecov bot commented Feb 4, 2020 •
edited
Loading

Codecov Report

Merging #2005 into release will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           release    #2005   +/-   ##
========================================
  Coverage    98.94%   98.94%           
========================================
  Files          147      147           
  Lines         6457     6457           
  Branches      1085     1085           
========================================
  Hits          6389     6389           
- Misses          67       68    +1     
+ Partials         1        0    -1
Impacted Files Coverage Δ
terminus-ui/select/src/select.component.ts 96.08% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f59e2ad...bba9018. Read the comment docs.

@github-actions github-actions bot added PR: awaiting review PRs that need to be reviewed Size: XL labels Feb 4, 2020
benjamincharity
benjamincharity suggested changes Feb 5, 2020
View reviewed changes
Copy link
Contributor

@benjamincharity benjamincharity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple tiny notes, otherwise it looks great! 🚀

terminus-ui/form-field/src/form-field.component.html Outdated Show resolved Hide resolved
terminus-ui/form-field/src/form-field.component.html Outdated Show resolved Hide resolved
terminus-ui/form-field/src/form-field.component.md Show resolved Hide resolved
terminus-ui/form-field/testing/src/test-components.ts Show resolved Hide resolved
terminus-ui/radio-group/src/radio-group.component.html Outdated Show resolved Hide resolved
terminus-ui/radio-group/src/radio-group.component.scss Show resolved Hide resolved
@atlwendy atlwendy force-pushed the 1756-formcontrol-no-validation branch from ddad7ce to f59e2ad Compare February 5, 2020 16:39
@github-actions github-actions bot added PR: approved PRs that have passed the review process and removed PR: awaiting review PRs that need to be reviewed labels Feb 5, 2020
@github-actions github-actions bot added the PR: awaiting review PRs that need to be reviewed label Feb 6, 2020
@benjamincharity benjamincharity merged commit 2fd3123 into release Feb 6, 2020
@benjamincharity benjamincharity deleted the 1756-formcontrol-no-validation branch February 6, 2020 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamincharity benjamincharity benjamincharity approved these changes

Assignees

@atlwendy atlwendy

Labels
PR: approved PRs that have passed the review process PR: awaiting review PRs that need to be reviewed Size: XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FormControls: Support 'no validation' mode
2 participants
@atlwendy @benjamincharity