Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "out of" count to the simple paginator if it's set #2047

Closed
deanterm opened this issue Feb 28, 2020 · 1 comment · Fixed by #2055
Closed

Add "out of" count to the simple paginator if it's set #2047

deanterm opened this issue Feb 28, 2020 · 1 comment · Fixed by #2055
Assignees
@deanterm
Labels
Focus: component Issues concerning a specific component Target: latest Issues related to the latest version of the library (master) Type: feature Functionality that doesn't currently exist

Comments

@deanterm
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Customers are requesting to be able to quickly see the number of records that are available on the simple paginator.

Describe the solution you'd like.

The record count for the simple paginator is currently not shown. You just see "1 - 10", "11 - 20", etc... If a count is available, show "1 - 10 of 100". If a count is not available, continue to use the previous method of "1 - 10" with no count.

Describe alternatives you've considered

None

Additional context
@deanterm deanterm added Needs: planning Items that need discovery/refinement/details/etc Type: feature Functionality that doesn't currently exist labels Feb 28, 2020
@deanterm
Copy link
Contributor Author

@deanterm is going to take this ticket. don't touch it our else!

@benjamincharity benjamincharity added Focus: component Issues concerning a specific component Target: latest Issues related to the latest version of the library (master) and removed Needs: planning Items that need discovery/refinement/details/etc labels Feb 28, 2020
deanterm added a commit to deanterm/terminus-ui that referenced this issue Mar 3, 2020
@deanterm
feat(Paginator): show "out of" total to simple paginator if total is …
4fd1589 
…available

We want to show "out of ___" on the simple paginator page label if the total is available. If it is
not, show the shortened version instead

BREAKING CHANGE:
GetTerminus#2047

ISSUES CLOSED: GetTerminus#2047
deanterm added a commit to deanterm/terminus-ui that referenced this issue Mar 3, 2020
@deanterm
feat(Paginator): show "out of" total to simple paginator if total is …
57c80e1 
…available

We want to show "out of ___" on the simple paginator page label if the total is available. If it is
not, show the shortened version instead

BREAKING CHANGE:

ISSUES CLOSED: GetTerminus#2047
deanterm added a commit to deanterm/terminus-ui that referenced this issue Mar 3, 2020
@deanterm
feat(Paginator): show "out of" total to simple paginator if total is …
088cc51 
…available

We want to show "out of ___" on the simple paginator page label if the total is available. If it is
not, show the shortened version instead

BREAKING CHANGE:

ISSUES CLOSED: GetTerminus#2047
@deanterm deanterm mentioned this issue Mar 3, 2020
Merged
benjamincharity pushed a commit to deanterm/terminus-ui that referenced this issue Mar 5, 2020
@deanterm @benjamincharity
feat(Paginator): show "out of" total to simple paginator if total is …
72a5f47 
…available

We want to show "out of ___" on the simple paginator page label if the total is available. If it is
not, show the shortened version instead

BREAKING CHANGE:

ISSUES CLOSED: GetTerminus#2047
benjamincharity pushed a commit to deanterm/terminus-ui that referenced this issue Mar 5, 2020
@deanterm @benjamincharity
feat(Paginator): show "out of" total to simple paginator if total is …
36d95bb 
…available

We want to show "out of ___" on the simple paginator page label if the total is available. If it is
not, show the shortened version instead

BREAKING CHANGE:

ISSUES CLOSED: GetTerminus#2047
benjamincharity pushed a commit that referenced this issue Mar 5, 2020
@deanterm @benjamincharity
feat(Paginator): show "out of" total to simple paginator if total is …
dd6c648 
…available

We want to show "out of ___" on the simple paginator page label if the total is available. If it is
not, show the shortened version instead

BREAKING CHANGE:

ISSUES CLOSED: #2047
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deanterm deanterm

Labels
Focus: component Issues concerning a specific component Target: latest Issues related to the latest version of the library (master) Type: feature Functionality that doesn't currently exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(Paginator): show "out of" total to simple paginator if total is available deanterm/terminus-ui
2 participants
@benjamincharity @deanterm