Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCSS: Add unit tests #952

Closed
4 of 5 tasks
benjamincharity opened this issue Jun 27, 2018 · 0 comments · Fixed by #1521
Closed
4 of 5 tasks

SCSS: Add unit tests #952

benjamincharity opened this issue Jun 27, 2018 · 0 comments · Fixed by #1521
Assignees
@shani-terminus
Labels
Focus: build Issues concerning our CI or build process' Needs: exploration Issues that need more information before being worked on P3: Important Type: chore Something that needs to be done but is not a bug or addition

Comments

@benjamincharity
Copy link
Contributor

benjamincharity commented Jun 27, 2018 •
edited by shani-terminus
Loading

https://seesparkbox.com/foundry/how_and_why_we_unit_test_our_sass

  • Add new tool as a dependency
  • Create a .spec.scss file by each helper SCSS file
  • Add tests for at least one mixin and one function
  • Create a new command to run the tests in package.json
  • Make sure that when the CI runs all our tests, these new tests are also run

NOTE: This ticket doesn't need all items tested. Just a couple to verify the approach works. We can then open up tickets to test other functions etc. (Some of the shadow functions are fairly complex and could blow up the scope of this ticket)
@benjamincharity benjamincharity added Focus: build Issues concerning our CI or build process' Needs: exploration Issues that need more information before being worked on P3: Important Type: chore Something that needs to be done but is not a bug or addition labels Jun 27, 2018
shani-terminus added a commit that referenced this issue May 23, 2019
@shani-terminus
chore(SCSS): created skeleton for testing SCSS
ba00a7b 
ISSUES CLOSED: #952
@shani-terminus shani-terminus mentioned this issue May 23, 2019
Closed
shani-terminus added a commit that referenced this issue May 23, 2019
@shani-terminus
chore(SCSS): created skeleton for testing SCSS
85f5870 
ISSUES CLOSED: #952
@shani-terminus shani-terminus mentioned this issue May 23, 2019
Merged
shani-terminus added a commit that referenced this issue May 28, 2019
@shani-terminus
chore(SCSS): created skeleton for testing SCSS
22f57ba 
ISSUES CLOSED: #952
benjamincharity pushed a commit that referenced this issue May 28, 2019
@shani-terminus @benjamincharity
chore(SCSS): created skeleton for testing SCSS (#1521)
cde99e3 
ISSUES CLOSED: #952
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shani-terminus shani-terminus

Labels
Focus: build Issues concerning our CI or build process' Needs: exploration Issues that need more information before being worked on P3: Important Type: chore Something that needs to be done but is not a bug or addition
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(SCSS): created skeleton for testing SCSS GetTerminus/terminus-ui
2 participants
@benjamincharity @shani-terminus