Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Wrong map colors #5238

Merged
merged 1 commit into from
Dec 22, 2024
Merged

fix: Wrong map colors #5238

merged 1 commit into from
Dec 22, 2024

Conversation

Adrigamer2950
Copy link
Contributor

This PR fixes #5236, that happened because RGB values where inverted (red where blue and viceversa)

@onebeastchris
Copy link
Member

Hey! Thanks for the PR.
Just as a note - the MapColor class is auto-generated by Geysers ' mapping-generator (specifically, here: https://github.com/GeyserMC/mappings-generator/blob/master/src%2Fmain%2Fjava%2Forg%2Fgeysermc%2Fgenerator%2FMappingsGenerator.java#L454-L488) - did you also use it to generate these changes, or did you change these by hand?

@onebeastchris onebeastchris linked an issue Dec 22, 2024 that may be closed by this pull request
Water blocks are incorrectly displaying as red on maps #5221
Closed
@Adrigamer2950
Copy link
Contributor Author

Adrigamer2950 commented Dec 22, 2024 •
edited
Loading

I just really reverted the changes made in 84faeba by hand, because after that commit the RGB values where inverted

@onebeastchris
Copy link
Member

Ah, thanks for linking that. I'll merge this PR, and will look into fixing the mappings generator later - these new incorrect values were generated using it :)

@onebeastchris onebeastchris merged commit 006fe75 into GeyserMC:master Dec 22, 2024
2 checks passed
rtm516 added a commit to rtm516/Geyser that referenced this pull request Dec 22, 2024
@rtm516
Revert "fix: Wrong map colors (GeyserMC#5238)"
1f167f7 
This reverts commit 006fe75.
@rtm516 rtm516 mentioned this pull request Dec 22, 2024
Merged
onebeastchris pushed a commit that referenced this pull request Dec 27, 2024
@rtm516
Fix map colors (#5239)
623ec2b 
* Revert "fix: Wrong map colors (#5238)"

This reverts commit 006fe75.

* Correctly send BGR over the network for map colors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onebeastchris onebeastchris onebeastchris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong Map Colors Water blocks are incorrectly displaying as red on maps
2 participants
@Adrigamer2950 @onebeastchris