Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServerChunkDataPacket is incorrectly encoding "Ground-Up Continuous" field #13

Closed
ghost opened this issue Jan 3, 2014 · 1 comment
Closed

Comments

@ghost
Copy link

ghost commented Jan 3, 2014

Currently it sets that field to true iff biomes are present. Instead it should be set to true if all 16 chunks are present and false if at least one of the chunks is null.

This was verified by connecting a vanilla mc client to a mcprotocollib server.

http://wiki.vg/Protocol#Chunk_Data

@ghost ghost closed this as completed Jan 3, 2014
@ghost
Copy link
Author

ghost commented Jan 3, 2014

I think you need another check to ensure that biome data is present when all chunks are present to ensure that this is consistent.

My server was sending all chunks without biome data. MCProtocolLib did not throw any exceptions even though this broke it's assumptions. Because I wasn't sending the biome data this field was incorrectly set to false. The vanilla client would not accept the packets unless the field was set to true. Once I set that field to true the vanilla client did not require biome data to be present and loaded up the chunks without issue.

Kas-tle pushed a commit to Kas-tle/MCProtocolLib that referenced this issue Mar 9, 2023
Change Disconnect message to the Throwable's message
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants