Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataPalette has an int field 'globalPaletteBits' which is not used #676

Closed
MatteCarra opened this issue Dec 4, 2021 · 2 comments
Closed

Comments

@MatteCarra
Copy link
Contributor

I was checking the ChunkSection.read method and I noticed it required a globalBiomePaletteBits.
I was not sure what it was and after inspecting the source I noticed that it was used to create a new DataPalette.
The problem is that it is not used there:

Am I missing something?

@Camotoy
Copy link
Member

Camotoy commented Dec 6, 2021

Seems like you're correct that it is unnecessary, yes.

@onebeastchris
Copy link
Member

Closing - this was resolved in the linked PR's.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants