Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataPalettes do not work correctly. #774

Closed
davidmayr opened this issue Dec 18, 2023 · 1 comment · Fixed by #775
Closed

DataPalettes do not work correctly. #774

davidmayr opened this issue Dec 18, 2023 · 1 comment · Fixed by #775

Comments

@davidmayr
Copy link
Contributor

I'm getting an index out of bounds exception on coordinates where it should be fully writable to.

How to reproduce?

Create a new chunk section
ChunkSection chunkSection = new ChunkSection();

attempt to write to position (0, 1, 0) which should be valid since biome palettes should be 4x4x4
chunkSection.getBiomeData().set(0, 1, 0, 5);

And you will receive an index out of bounds exception.
@davidmayr
Copy link
Contributor Author

Maybe #676 is related?

@davidmayr davidmayr mentioned this issue Dec 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix DataPalette index & deprecate unused globalPaletteBits cafestube/MCProtocolLib
1 participant
@davidmayr