Fixed: Added missing MoveToHotbarAction value for the swap with off-hand inventory action. #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This inventory action is triggered when a player has their inventory open and clicks on some slot with the
Fkey.This case is also documented here: https://wiki.vg/Protocol#Click_Window
I noticed this because client sessions in a simple private Minecraft server proxy that uses this library were silently (without stack trace or anything) closed whenever the player uses this inventory action. Adding this MoveToHotbarAction value was confirmed to resolve the issue.