Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix (de)serialization of ClientboundExplodePacket #776

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Fix (de)serialization of ClientboundExplodePacket #776

merged 2 commits into from
Dec 19, 2023

Conversation

Konicai
Copy link
Member

@Konicai Konicai commented Dec 19, 2023

I followed the mojang field order for the fields, but missed the part where they serialize in a slightly different order.

@Konicai Konicai changed the title Explosions Fix (de)serialization of ClientboundExplodePacket Dec 19, 2023
@Konicai Konicai merged commit 2a76b37 into master Dec 19, 2023
3 checks passed
@Konicai Konicai deleted the explosions branch December 19, 2023 07:41
@Konicai Konicai mentioned this pull request Dec 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onebeastchris onebeastchris onebeastchris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Konicai @onebeastchris