Allow using arbitrary json as the status packet #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Konicai
requested changes
May 22, 2024
...ysermc/mcprotocollib/protocol/packet/status/clientbound/ClientboundStatusResponsePacket.java
Show resolved
Hide resolved
...ysermc/mcprotocollib/protocol/packet/status/clientbound/ClientboundStatusResponsePacket.java
Outdated
Show resolved
Hide resolved
Camotoy
reviewed
May 24, 2024
...ysermc/mcprotocollib/protocol/packet/status/clientbound/ClientboundStatusResponsePacket.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd prefer using any arbitrary jsonobject as the status packet payload to support third-party modloader fields.
The implementation keeps support for the typed json data, but allows the user to additionally provide any json object they want.
I don't think this is outside of the scope of the project as this could allow people building a MCPL client (like me) to detect if a server to connect to is a forge server to enable different logic/prevent joining due to different protocol.
my current workaround is registering my own status data packet, which is a thing i wanna stop doing