Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search for Findings in Reports #400

Closed
BrunoTeixeira1996 opened this issue Feb 29, 2024 · 8 comments · Fixed by #526
Closed

Search for Findings in Reports #400

BrunoTeixeira1996 opened this issue Feb 29, 2024 · 8 comments · Fixed by #526
Labels
enhancement New feature or request

Comments

@BrunoTeixeira1996
Copy link

Is your feature request related to a problem? Please describe.
I'm always frustated when some collegue does not create a custom Finding and I need to lookup each previous report to find what they did do describe let's say a CSV Injection.

Describe the solution you'd like
A cool feature would be to have a search for a finding but inside the reports so I can lookup what my collegue wrote when describring a finding that is not in the finding tabs.

Would this be possible? Thanks

@ArgentEnergy
Copy link

@BrunoTeixeira1996 @chrismaddalena

I believe what Bruno is asking is what we do at my work. I wrote a custom web page that allows me to filter report findings based on tester, date, keywords (e.g. JWT, XML, GraphQL, etc...), and then click the finding title to go to the report.

You'll probably have to re-adjust our code as we use the affected entities field as the finding evidence field to write up all our finding details and we use some other fields as shown in the screenshot to categorize findings into buckets (e.g. Authentication, Encryption, etc...).

https://github.com/StratumSecurity/Ghostwriter/blob/5219255bd7397440b16ff3c0435a5dedc271e6a2/config/urls.py - has the entry for the URL mapping: report/findings/
https://github.com/StratumSecurity/Ghostwriter/blob/5219255bd7397440b16ff3c0435a5dedc271e6a2/ghostwriter/stratum/filters.py - code to handle different types of filtering
https://github.com/StratumSecurity/Ghostwriter/blob/5219255bd7397440b16ff3c0435a5dedc271e6a2/ghostwriter/stratum/templates/report_findings_list.html - webpage HTML code
https://github.com/StratumSecurity/Ghostwriter/blob/5219255bd7397440b16ff3c0435a5dedc271e6a2/ghostwriter/stratum/urls.py - URL mapping
https://github.com/StratumSecurity/Ghostwriter/blob/5219255bd7397440b16ff3c0435a5dedc271e6a2/ghostwriter/stratum/views.py - API code for the page
https://github.com/StratumSecurity/Ghostwriter/blob/5219255bd7397440b16ff3c0435a5dedc271e6a2/ghostwriter/templates/base_generic.html - has the Search Report Findings menu item entry there
Screenshot 2024-03-04 at 8 21 51 AM
Screenshot 2024-03-04 at 8 22 02 AM

@BrunoTeixeira1996
Copy link
Author

@ArgentEnergy that is exactly what I was looking for however I can't use your fork at work but I think this would be a realy cool feature.
I was thinking on doing something similar just by using a cli something like a grep but I had to have admin rigths for that

@chrismaddalena
Copy link
Collaborator

We're tracking this and will see what we can implement 😄

@chrismaddalena chrismaddalena added the enhancement New feature or request label Apr 10, 2024
Copy link

github-actions bot commented Jun 1, 2024

This issue has been labeled as stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Jun 1, 2024
Copy link

This issue is closed because it has been inactive for 14 days since being labeled stale. Feel free to re-open the issue with a comment. If this needs further discussion (e.g., a feature request), it might be better to open a topic under the Discussions tab.

@BrunoTeixeira1996
Copy link
Author

Any update? @chrismaddalena

@chrismaddalena
Copy link
Collaborator

This issue is closed but tracked on the road map. No update on this one yet, but we'll look at ArgentEnergy's implementation.

@BrunoTeixeira1996
Copy link
Author

This issue is closed but tracked on the road map. No update on this one yet, but we'll look at ArgentEnergy's implementation.

Awesome, thanks for the feedback!

ColonelThirtyTwo added a commit to ColonelThirtyTwo/Ghostwriter that referenced this issue Sep 17, 2024
Add checkbox to the findings list to search on report findings instead.

Implements GhostManager#400
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Released
Development

Successfully merging a pull request may close this issue.

4 participants