Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set to default_pptx_template #528

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

domwhewell-sage
Copy link
Contributor

Closes #527
As mentioned in the linked issue the ArchiveView defaults to the default_docx_template by mistake when the report has no pptx_template configured

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.85%. Comparing base (e56d9e3) to head (fd43d01).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
ghostwriter/reporting/views.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #528   +/-   ##
=======================================
  Coverage   91.84%   91.85%           
=======================================
  Files         319      319           
  Lines       18573    18573           
=======================================
+ Hits        17059    17060    +1     
+ Misses       1514     1513    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrismaddalena
Copy link
Collaborator

Thanks for the catch and for submitting a PR!

@chrismaddalena chrismaddalena merged commit 32fabbe into GhostManager:master Sep 30, 2024
7 of 8 checks passed
@domwhewell-sage domwhewell-sage deleted the patch-1 branch September 30, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ArchiveView Bug
2 participants