Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file error reporting #6

Merged
merged 2 commits into from
May 14, 2021
Merged

Add file error reporting #6

merged 2 commits into from
May 14, 2021

Conversation

EamonnMR
Copy link
Contributor

GDScriptAudioImport will fail silently if the load fails, which made debugging a bit of a pain. This adds some logging that indicates if a file load has failed and if so, why. It also returns an empty audio stream to allow the calling script to gracefully continue.

GDScriptAudioImport will fail silently if the load fails, which made debugging a bit of a pain. This adds some logging that indicates if a file load has failed and if so, why. It also returns an empty audio stream to allow the calling script to gracefully continue.
That added a param to hide all non-error logging, but I can submit that as a different patch.
@EamonnMR
Copy link
Contributor Author

It was by adding this logging that I discovered an unfortunate fact: godot absolutely refuses to let you keep a .wav or .ogg file in your pck, even if you specifically include it in the export settings. The existence of this project suggests that someone has gotten it working though; if there's a workaround for .wav/.ogg export behavior, it's probably worth adding to the readme.

Copy link

@sairam4123 sairam4123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@4321ba
Copy link
Contributor

4321ba commented Apr 22, 2021

It was by adding this logging that I discovered an unfortunate fact: godot absolutely refuses to let you keep a .wav or .ogg file in your pck, even if you specifically include it in the export settings. The existence of this project suggests that someone has gotten it working though; if there's a workaround for .wav/.ogg export behavior, it's probably worth adding to the readme.

actually they reworked that part and you can keep files in the new 3.3 version as-is using "Keep" as import option iirc
https://godotengine.org/article/editor-improvements-godot-40 (they backported that)
godotengine/godot#47268

also, the owner of the repo seemed pretty fast to respond to my contribution, they might have missed this one, you could maybe try pinging them

@Gianclgar Gianclgar merged commit 1d87aef into Gianclgar:master May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants