User Admin - refactored all breadcrumbs

[leofreitas]

Hi,
I finished this module, and would started the module activies.

[SKuipers]

Wow, this is looking great!! 😃 I've highlighted a couple quick changes. Also, the __() translation function no longer required a $guid, so in your updated breadcrumbs can you remove any of the cases where the method begins with __($guid. I'll add this to the gist notes too. Thanks!

[rossdotparker]

Wow, Leo you've been busy! I will leave look at this one tomorrow and aim to merge it in. Thanks : )

[leofreitas]

Hi Sandra and Ross,
I'm sorry, I don't know how I didn't see this! :-)

[SKuipers]

Thanks! Looks great. I've setup an issue so we can track the refactoring progress: #696

[yookoala]

@SKuipers: Does the auto-generated breadcrumb object include the module name and path already? Or do we need to do a manual ->add(__(getModuleName($_GET["q"])), getModuleEntry($_GET["q"], $connection2, $guid)) in the middle (when refactoring the breadcrumb)?

[SKuipers]

Yep, it includes the module name & entry point already. Be sure to check out the instructions 😃

[rossdotparker]

@leofreitas can you let me know when you feel this is ready to be merged, and I will take a look. Thanks!

[leofreitas]

@rossdotparker this pullrequest is ready to be merge. thanks!

[rossdotparker]

@leofreitas it looks good : ) but, you seem to have deleted uploads/.htaccess. Please can you restore this file, and then I will merge and test. Thanks!

[SKuipers]

🤦‍♀️ I missed that! Well spotted.

[leofreitas]

Hi @rossdotparker,
I restored the folder uploads.
@SKuipers, I had removed breadcrumbs on delete action, but the travis show me a lot of fails and then I undid.

[rossdotparker]

Hi Leo, thanks for persisting with this! The issue with the delete breadcrumbs is that the refactoring will cause a PHP error, which is worse than a Travis error. If you can remove them again, I'll then merge, and we can fix the tests to keep Travis happy. Sorry to create more work for you, hopefully it won't take long!

[SKuipers]

I've updated all the tests to no longer check for breadcrumbs on the delete action. Thanks!