Library: refactor breadcrumbs #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yookoala
force-pushed
the
library-breadcrumb
branch
from
0d9556d to
6e75aba
Compare
SKuipers
requested changes
Nov 8, 2018
|
@SKuipers: Sure. |
yookoala
force-pushed
the
library-breadcrumb
branch
from
6e75aba to
eafec60
Compare
|
Done. |
SKuipers
reviewed
Nov 8, 2018
yookoala
force-pushed
the
library-breadcrumb
branch
from
eafec60 to
5e0f2a5
Compare
* adapt the new `$page` global for breadcrumb.
yookoala
force-pushed
the
library-breadcrumb
branch
from
5e0f2a5 to
462a77a
Compare
SKuipers
approved these changes
Nov 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
Description
adapt the new
$pageglobal for breadcrumb.Motivation and Context
See #696
How Has This Been Tested?