-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 実績を解除した際に実績の小区分を表示する機能 #2382
Merged
rito528
merged 11 commits into
GiganticMinecraft:1_18
from
kuroma6666:feat-display-achievements-detail
Oct 14, 2024
Merged
feat: 実績を解除した際に実績の小区分を表示する機能 #2382
rito528
merged 11 commits into
GiganticMinecraft:1_18
from
kuroma6666:feat-display-achievements-detail
Oct 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@rito528 |
rito528
requested changes
Oct 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM.
src/main/scala/com/github/unchama/seichiassist/achievement/hierarchy/AchievementGroup.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/github/unchama/seichiassist/achievement/hierarchy/AchievementGroup.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/github/unchama/seichiassist/achievement/hierarchy/AchievementGroup.scala
Outdated
Show resolved
Hide resolved
...la/com/github/unchama/seichiassist/menus/achievement/group/AchievementGroupMenuButtons.scala
Outdated
Show resolved
Hide resolved
@rito528 |
rito528
approved these changes
Oct 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM👍👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #920
このPRの変更点と理由:
補足情報: