Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 実績を解除した際に実績の小区分を表示する機能 #2382

Merged

Conversation

kuroma6666
Copy link
Contributor

close #920


このPRの変更点と理由:

  • 実績解除時の表示内容に小区分を同時に表示するようにした。
  • 自動解禁・手動解禁の両方に対応

補足情報:

@kuroma6666
Copy link
Contributor Author

@rito528
こちらのPRについて、お手すきの際にご確認お願いします

Copy link
Member

@rito528 rito528 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM.

@kuroma6666
Copy link
Contributor Author

@rito528
ご指摘いただいた内容について修正したので、確認お願いします。

Copy link
Member

@rito528 rito528 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍👍

@rito528 rito528 merged commit 2669f07 into GiganticMinecraft:1_18 Oct 14, 2024
1 check passed
@kuroma6666 kuroma6666 deleted the feat-display-achievements-detail branch October 14, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants