Merge upstream #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(clipboard): implement clipboard integration Add the --clipboard flag and implement functionality to make image available on the clipboard using wl-clipboard-rs. * style(format): apply code formatting to cli.rs * feat(clipboard): implement fork wait for clipboard Add functionality offering image on clipboard persistently in the background * feat(clipboard): inform user about wayshot persisting in background with --clipboard * feat(clipboard): use tracing::warn instead of print if fork fails * feat(clipboard): Switch from the fork crate to the nix crate for daemonization * style(format): code formatting to wayshot.rs * style(typo): corrected a typo in the comments
Signed-off-by: Shinyzenith <aakashsensharma@gmail.com>
Signed-off-by: Shinyzenith <aakashsensharma@gmail.com>
Signed-off-by: Shinyzenith <aakashsensharma@gmail.com>
* feat: added time_stamp flag
* Syntax Refactor and filename format fixed
* file name format fixes
* wayshot-{timestamp}.{extension} as default filename
* chore: Update Cargo.lock
Signed-off-by: Shinyzenith <aakashsensharma@gmail.com>
---------
Signed-off-by: Shinyzenith <aakashsensharma@gmail.com>
Authored-by: rachancheet <raxxsngh37@gmail.com>
Co-authored-by: Shinyzenith <aakashsensharma@gmail.com>
Signed-off-by: Shinyzenith <aakashsensharma@gmail.com>
Signed-off-by: Shinyzenith <aakashsensharma@gmail.com> --------- Signed-off-by: Shinyzenith <aakashsensharma@gmail.com> Co-authored-by: Shinyzenith <aakashsensharma@gmail.com>
* refactor: remove unnecessary to_string() * refactor: fix clippy warnings * refactor: remove 1 level of indirection via &Vec<T> -> &[T] Typically `&Vec<T>` isn't something you want when you need a read-only view over a Vec, because it adds another level of indirection: Vec already stores a pointer to heap-allocated buffer internally. Using slices `&[T]` removes such unnecessary level of indirection and is considered a cleaner design. It is cache friendlier and can be better optimized by the compiler (not that it should matter in this case).
Signed-off-by: Shinyzenith <aakashsensharma@gmail.com> --------- Signed-off-by: Shinyzenith <aakashsensharma@gmail.com> Authored-by: rachancheet <raxxsngh37@gmail.com> Co-authored-by: Shinyzenith <aakashsensharma@gmail.com>
* feat(clipboard): fix issue #106 clipboard flag ignored if path is qualified to file * feat(clipboard): clarify flag description of --clipboard * feat(clipboard): enable multiline comment description for --clipboard feature flag Signed-off-by: Shinyzenith <aakashsensharma@gmail.com> * feat(clipboard): reduce buffer allocations for encoding image * feat(clipboard): improve code quality * feat(clipboard): code style change: perform match inside function call --------- Signed-off-by: Shinyzenith <aakashsensharma@gmail.com> Co-authored-by: Shinyzenith <aakashsensharma@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.