Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new type: Dominating Set problem (without weights) #48

Merged
merged 8 commits into from
Jul 25, 2024

Conversation

SciCodePhy
Copy link
Collaborator

No description provided.

@SciCodePhy SciCodePhy marked this pull request as draft July 24, 2024 01:30
@SciCodePhy SciCodePhy changed the title Add new type: Dominating Set problem (without weights) Add a new type: Dominating Set problem (without weights) Jul 24, 2024
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.85%. Comparing base (e735c83) to head (cfc8c9c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
+ Coverage   88.67%   88.85%   +0.18%     
==========================================
  Files          16       17       +1     
  Lines         680      691      +11     
==========================================
+ Hits          603      614      +11     
  Misses         77       77              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SciCodePhy SciCodePhy marked this pull request as ready for review July 24, 2024 02:08
@SciCodePhy
Copy link
Collaborator Author

SciCodePhy commented Jul 24, 2024

A possible typo in test/rules/rules.jl [ #44 ]

Original:
@testset "spinglass_sat" begin include("spinglass_maxcut.jl") end

Should be:
@testset "spinglass_maxcut" begin include("spinglass_maxcut.jl") end

@SciCodePhy
Copy link
Collaborator Author

Conflicts resolved.

We don't have weights for this problem.
"""
struct DominatingSet{ GT<:AbstractGraph} <: AbstractProblem
graph::GT
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each vertex can be associated with a weight.

@SciCodePhy SciCodePhy merged commit 3543363 into main Jul 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants