[WIP] New factoring #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #62 +/- ##
==========================================
- Coverage 92.93% 92.24% -0.70%
==========================================
Files 26 28 +2
Lines 1076 1147 +71
==========================================
+ Hits 1000 1058 +58
- Misses 76 89 +13 ☔ View full report in Codecov by Sentry. |
….jl into jg/factoring
….jl into jg/factoring
c-allergic
approved these changes
Aug 13, 2024
src/rules/factoring_sat.jl
Outdated
| # s + 2c = p*q + s_pre + c_pre | ||
| c = BooleanExpr(Symbol("c$i$j")) | ||
| s = BooleanExpr(Symbol("s$i$j")) | ||
| mul_exprs, ancillas = multiplier(s, c, p[i], q[j], j == n2 ? BooleanExpr(:false) : spres[j+1], cpre) |
There was a problem hiding this comment.
ERROR: BoundsError: attempt to access 0-element Vector{BooleanExpr} at index [2] since the spres and cpres are empty vector. So maybe initialize the vector by pushing zeros. But 0 (1) is not defined in BoolExpr, also the false & true
test/rules/factoring_sat.jl
Outdated
| # res4 = reduceto(CircuitSAT, fact4) | ||
| # best_configs4 = findbest(target_problem(res4), BruteForce()) <- this step is slow and we can't get the result ,stucked. maybe improve it | ||
| # @test length(best_configs4) == 2 | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.